Provide a maximum size on the number of tests to run in one group.

Provide a maximum size on the number of tests to run in one group.

The implementation of thread local storage on Android does not free slots
in a fixed size datastructure with 256 slots. When a large number of tests
run in a single process it is easy to exceed the limit. We don't have
control over how many slots are burnt per test, so we just assume that
one slot is burnt per test. We split the tests so only 256 run in a given
process.

BUG=354405
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289386

[Sami, 2014-08-08 12:51:23]

Thanks, lgtm if you also add a test :)

https://codereview.chromium.org/453953003/diff/1/build/android/pylib/base/tes...
File build/android/pylib/base/test_dispatcher.py (right):

https://codereview.chromium.org/453953003/diff/1/build/android/pylib/base/tes...
build/android/pylib/base/test_dispatcher.py:352: max_per_run: Maxium number of
tests to run in any group.
s/Maxium/Maximum/

[anton1, 2014-08-08 13:23:03]

On 2014/08/08 12:51:23, Sami wrote:
> Thanks, lgtm if you also add a test :)
> 
>
https://codereview.chromium.org/453953003/diff/1/build/android/pylib/base/tes...
> File build/android/pylib/base/test_dispatcher.py (right):
> 
>
https://codereview.chromium.org/453953003/diff/1/build/android/pylib/base/tes...
> build/android/pylib/base/test_dispatcher.py:352: max_per_run: Maxium number of
> tests to run in any group.
> s/Maxium/Maximum/

I have added a test and removed a broken one.

[Sami, 2014-08-08 13:32:41]

lgtm, thank you!

[rmcilroy, 2014-08-08 13:36:06]

On 2014/08/08 13:23:03, anton1 wrote:
> On 2014/08/08 12:51:23, Sami wrote:
> > Thanks, lgtm if you also add a test :)
> > 
> >
>
https://codereview.chromium.org/453953003/diff/1/build/android/pylib/base/tes...
> > File build/android/pylib/base/test_dispatcher.py (right):
> > 
> >
>
https://codereview.chromium.org/453953003/diff/1/build/android/pylib/base/tes...
> > build/android/pylib/base/test_dispatcher.py:352: max_per_run: Maxium number
of
> > tests to run in any group.
> > s/Maxium/Maximum/
> 
> I have added a test and removed a broken one.

Looks like this has been changed from an assert failure to logging an error, so
it seems OK to remove this test.

lgtm, thanks Anton!

[anton1, 2014-08-08 13:36:33]

The CQ bit was checked by anton@google.com

[commit-bot: I haz the power, 2014-08-08 13:37:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anton@chromium.org/453953003/40001

[commit-bot: I haz the power, 2014-08-08 15:05:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-08 16:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-08 16:18:20]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[rmcilroy, 2014-08-13 14:42:15]

On 2014/08/08 16:18:20, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_dbg_triggered_tests on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

lgtm

[Anton, 2014-08-13 16:16:39]

The CQ bit was checked by anton@chromium.org

[commit-bot: I haz the power, 2014-08-13 16:18:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anton@chromium.org/453953003/100001

[commit-bot: I haz the power, 2014-08-13 18:16:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-13 18:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 18:42:24]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[rmcilroy, 2014-08-13 19:06:33]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2014-08-13 19:08:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/anton@chromium.org/453953003/100001

[commit-bot: I haz the power, 2014-08-13 20:18:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-13 21:46:42]

Committed patchset #6 (100001) as 289386