Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 453953002: Set ScopeInfo when compiling for unit tests. (Closed)

Created:
6 years, 4 months ago by sigurds
Modified:
6 years, 4 months ago
Reviewers:
Michael Starzinger
Project:
v8
Visibility:
Public.

Description

Set ScopeInfo when compiling for unit tests. This is required to correctly treat eval in unit tests. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23193

Patch Set 1 #

Total comments: 9

Patch Set 2 : Set ScopeInfo when compiling for unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M test/cctest/compiler/function-tester.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sigurds
https://codereview.chromium.org/453953002/diff/1/test/cctest/compiler/function-tester.h File test/cctest/compiler/function-tester.h (right): https://codereview.chromium.org/453953002/diff/1/test/cctest/compiler/function-tester.h#newcode50 test/cctest/compiler/function-tester.h:50: if (!info.shared_info().is_null()) { Please advice if you think the ...
6 years, 4 months ago (2014-08-08 11:53:44 UTC) #1
Michael Starzinger
LGTM with comments. https://codereview.chromium.org/453953002/diff/1/test/cctest/compiler/function-tester.h File test/cctest/compiler/function-tester.h (right): https://codereview.chromium.org/453953002/diff/1/test/cctest/compiler/function-tester.h#newcode50 test/cctest/compiler/function-tester.h:50: if (!info.shared_info().is_null()) { On 2014/08/08 11:53:44, ...
6 years, 4 months ago (2014-08-14 08:48:08 UTC) #2
sigurds
Will land once nopush is gone. https://codereview.chromium.org/453953002/diff/1/test/cctest/compiler/function-tester.h File test/cctest/compiler/function-tester.h (right): https://codereview.chromium.org/453953002/diff/1/test/cctest/compiler/function-tester.h#newcode50 test/cctest/compiler/function-tester.h:50: if (!info.shared_info().is_null()) { ...
6 years, 4 months ago (2014-08-14 09:53:34 UTC) #3
sigurds
6 years, 4 months ago (2014-08-19 11:24:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698