Issue 453943003: Fix crash in blink::DOMWindowEventQueue::close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453943003: Fix crash in blink::DOMWindowEventQueue::close (Closed)

Created:
6 years, 4 months ago by aandrey

Modified:
6 years, 4 months ago

Reviewers:
pfeldman, yurys

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix crash in blink::DOMWindowEventQueue::close BUG=395991 R=yurys, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179929

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	Source/core/events/DOMWindowEventQueue.cpp	View		1 chunk	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

aandrey

https://codereview.chromium.org/453943003/diff/1/Source/core/events/DOMWindowEventQueue.cpp File Source/core/events/DOMWindowEventQueue.cpp (right): https://codereview.chromium.org/453943003/diff/1/Source/core/events/DOMWindowEventQueue.cpp#newcode128 Source/core/events/DOMWindowEventQueue.cpp:128: bool wasAdded = m_queuedEvents.add(nullptr).isNewEntry; there can be NULL's in ...

6 years, 4 months ago (2014-08-08 14:07:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/453943003/1

6 years, 4 months ago (2014-08-11 08:41:48 UTC) #4

Message was sent while issue was closed.

Change committed as 179929

Expand Messages | Collapse Messages