Issue 453893002: Add a force-layout-height-to-zero layout mode to WebViewImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453893002: Add a force-layout-height-to-zero layout mode to WebViewImpl (Closed)

Created:
6 years, 4 months ago by mkosiba (inactive)

Modified:
6 years, 4 months ago

Reviewers:
aelias_OOO_until_Jul13, mnaganov (inactive), abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Add a force-layout-height-to-zero layout mode to WebViewImpl This makes it possible for the android_webview to implement 'wrap_content' mode for the view's height without completely ignoring the viewport meta tag (like it's doing now). TBR=abarth@chromium.org, aelias@chromium.org, mnaganov@chromium.org BUG=392460 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179823

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -0 lines)			Patch
M	Source/core/frame/Settings.in	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	Source/web/WebSettingsImpl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/WebSettingsImpl.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	public/web/WebSettings.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

mkosiba (inactive)

This is a re-land of https://codereview.chromium.org/382543003/ with a minor change to the tests to make ...

6 years, 4 months ago (2014-08-08 10:02:33 UTC) #1

mkosiba (inactive)

The CQ bit was checked by mkosiba@chromium.org

6 years, 4 months ago (2014-08-08 10:02:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/453893002/1

6 years, 4 months ago (2014-08-08 10:03:31 UTC) #3

Message was sent while issue was closed.

Change committed as 179823