Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-original.cc

Issue 453873002: Implement rewrite logic for assigning a temporary scoped_refptr to T*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename tests, etc Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-original.cc
diff --git a/tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-original.cc b/tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-original.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1458a0bc3d65a4ca285c916214b9e506da76f696
--- /dev/null
+++ b/tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-original.cc
@@ -0,0 +1,21 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "scoped_refptr.h"
+
+struct Foo {
+ int dummy;
+};
+
+// Similar to case 2, except the result is being used in a boolean test. This
+// doesn't result in memory safety issues but it could be easily argued that
+// this is a bad way to structure the code. The tool should ignore this case so
+// that it can be manually handled by human intervention.
+scoped_refptr<Foo> GetBuggyFoo() {
+ return new Foo;
+}
+void UseBuggyFoo() {
+ if (GetBuggyFoo())
+ return;
+}

Powered by Google App Engine
This is Rietveld 408576698