Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-original.cc

Issue 453873002: Implement rewrite logic for assigning a temporary scoped_refptr to T*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-original.cc
diff --git a/tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-original.cc b/tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-original.cc
new file mode 100644
index 0000000000000000000000000000000000000000..00435f031472463a2eefedebf31bda646c0b6ac0
--- /dev/null
+++ b/tools/clang/rewrite_scoped_refptr/tests/temp-passed-as-raw-arg-original.cc
@@ -0,0 +1,24 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "scoped_refptr.h"
+
+struct Foo {
+ int dummy;
+};
+
+// A temporary scoped_refptr is passed as a raw pointer function argument. Since
+// temporaries are destroyed at the end of the full expression, this is 'safe'
+// and could be rewritten to use get(). However, the tool just skips this case
+// This should be rare enough that manual intervention is sufficient, since
+// seeing this pattern probably indicates a code smell.
+scoped_refptr<Foo> GetBuggyFoo() {
+ return new Foo;
+}
+
+void Bar(Foo* f);
+
+void UseBuggyFoo() {
+ Bar(GetBuggyFoo());
+}

Powered by Google App Engine
This is Rietveld 408576698