Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc

Issue 453873002: Implement rewrite logic for assigning a temporary scoped_refptr to T*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc
diff --git a/tools/clang/rewrite_scoped_refptr/tests/test2-expected.cc b/tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc
similarity index 54%
copy from tools/clang/rewrite_scoped_refptr/tests/test2-expected.cc
copy to tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc
index dd6e0ee9ba67dd2abaad427750ce8623808d4cf5..815d78a9b9a9b733fb946557ccc0e7ae75b73661 100644
--- a/tools/clang/rewrite_scoped_refptr/tests/test2-expected.cc
+++ b/tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc
@@ -8,12 +8,13 @@ struct Foo {
int dummy;
};
-// Case 2: An example of an unsafe conversion, where the scoped_refptr<> is
-// returned as a temporary, and as such both it and its object are only valid
-// for the duration of the full expression.
+// A temporary scoped_refptr<T> is used in a boolean test. This doesn't result
+// in memory safety issues, but probably indicates a code smell. As such, the
+// tool intentionally skips this case so it can be manually handled.
scoped_refptr<Foo> GetBuggyFoo() {
return new Foo;
}
void UseBuggyFoo() {
- Foo* unsafe = GetBuggyFoo();
+ if (GetBuggyFoo())
+ return;
}

Powered by Google App Engine
This is Rietveld 408576698