| Index: tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc
|
| diff --git a/tools/clang/rewrite_scoped_refptr/tests/test2-expected.cc b/tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc
|
| similarity index 54%
|
| copy from tools/clang/rewrite_scoped_refptr/tests/test2-expected.cc
|
| copy to tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc
|
| index dd6e0ee9ba67dd2abaad427750ce8623808d4cf5..815d78a9b9a9b733fb946557ccc0e7ae75b73661 100644
|
| --- a/tools/clang/rewrite_scoped_refptr/tests/test2-expected.cc
|
| +++ b/tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-expected.cc
|
| @@ -8,12 +8,13 @@ struct Foo {
|
| int dummy;
|
| };
|
|
|
| -// Case 2: An example of an unsafe conversion, where the scoped_refptr<> is
|
| -// returned as a temporary, and as such both it and its object are only valid
|
| -// for the duration of the full expression.
|
| +// A temporary scoped_refptr<T> is used in a boolean test. This doesn't result
|
| +// in memory safety issues, but probably indicates a code smell. As such, the
|
| +// tool intentionally skips this case so it can be manually handled.
|
| scoped_refptr<Foo> GetBuggyFoo() {
|
| return new Foo;
|
| }
|
| void UseBuggyFoo() {
|
| - Foo* unsafe = GetBuggyFoo();
|
| + if (GetBuggyFoo())
|
| + return;
|
| }
|
|
|