tools/clang/rewrite_scoped_refptr/tests/temp-assigned-to-field-init-original.cc - Issue 453873002: Implement rewrite logic for assigning a temporary scoped_refptr to T*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/rewrite_scoped_refptr/tests/temp-assigned-to-field-init-original.cc

Issue 453873002: Implement rewrite logic for assigning a temporary scoped_refptr to T*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/rewrite_scoped_refptr/tests/temp-assigned-to-field-init-expected.cc ('k') | tools/clang/rewrite_scoped_refptr/tests/temp-assigned-to-raw-var-expected.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/rewrite_scoped_refptr/tests/temp-assigned-to-field-init-original.cc

diff --git a/tools/clang/rewrite_scoped_refptr/tests/test10-expected.cc b/tools/clang/rewrite_scoped_refptr/tests/temp-assigned-to-field-init-original.cc

similarity index 56%

copy from tools/clang/rewrite_scoped_refptr/tests/test10-expected.cc

copy to tools/clang/rewrite_scoped_refptr/tests/temp-assigned-to-field-init-original.cc

index a74cd7df9336d8cb9a80f3b4952beb6cea30c6df..c81503ce4a02e9c1907c2d8b508adbfcb8a7899c 100644

--- a/tools/clang/rewrite_scoped_refptr/tests/test10-expected.cc

+++ b/tools/clang/rewrite_scoped_refptr/tests/temp-assigned-to-field-init-original.cc

@@ -8,9 +8,12 @@ struct Foo {

int dummy;

};

-int TestsAScopedRefptr() {

- scoped_refptr<Foo> foo(new Foo);

- if (foo.get())

- return 1;

- return 0;

+// Similar to case 2, but with a field initializer.

+scoped_refptr<Foo> GetBuggyFoo() {

+ return new Foo;

}

+class ABuggyCtor {

+ ABuggyCtor() : f_(GetBuggyFoo()) {}

+ Foo* f_;

+};