OLD | NEW |
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "scoped_refptr.h" | 5 #include "scoped_refptr.h" |
6 | 6 |
7 struct Foo { | 7 struct Foo { |
8 int dummy; | 8 int dummy; |
9 }; | 9 }; |
10 | 10 |
11 // Case 2: An example of an unsafe conversion, where the scoped_refptr<> is | 11 // A temporary scoped_refptr<T> is used in a boolean test. This doesn't result |
12 // returned as a temporary, and as such both it and its object are only valid | 12 // in memory safety issues, but probably indicates a code smell. As such, the |
13 // for the duration of the full expression. | 13 // tool intentionally skips this case so it can be manually handled. |
14 scoped_refptr<Foo> GetBuggyFoo() { | 14 scoped_refptr<Foo> GetBuggyFoo() { |
15 return new Foo; | 15 return new Foo; |
16 } | 16 } |
17 void UseBuggyFoo() { | 17 void UseBuggyFoo() { |
18 Foo* unsafe = GetBuggyFoo(); | 18 if (GetBuggyFoo()) |
| 19 return; |
19 } | 20 } |
OLD | NEW |