tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc - Issue 453873002: Implement rewrite logic for assigning a temporary scoped_refptr to T*.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-expected.cc

Issue 453873002: Implement rewrite logic for assigning a temporary scoped_refptr to T*. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more changes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/clang/rewrite_scoped_refptr/tests/const-scoped_refptr&-to-raw-adds-get-original.cc ('k') | tools/clang/rewrite_scoped_refptr/tests/local-returned-as-raw-original.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "scoped_refptr.h"	5 #include "scoped_refptr.h"

6	6

7 struct Foo {	7 struct Foo {

8 int dummy;	8 int dummy;

9 };	9 };

10	10

11 // Case 1: An example of an unsafe conversion, where the object is freed by	11 // Case 1: An example of an unsafe conversion, where the object is freed by

12 // the time the function returns.	12 // the time the function returns.

13 Foo* GetBuggyFoo() {	13 Foo* GetBuggyFoo() {

14 scoped_refptr<Foo> unsafe(new Foo);	14 scoped_refptr<Foo> unsafe(new Foo);

	15 // FIXME: The tool should rewrite the return type of the function.

15 return unsafe.get();	16 return unsafe.get();

16 }	17 }

OLD	NEW