components/copresence/copresence_client.cc - Issue 453793002: Add audible support to the copresence API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/copresence/copresence_client.cc

Issue 453793002: Add audible support to the copresence API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/copresence/copresence_client.cc

diff --git a/components/copresence/copresence_client.cc b/components/copresence/copresence_client.cc

index 17f906b59f3516e8cddd2bd9cf328cf7c77e5477..abb90c1c07123d527001d47de07bad65a016de38 100644

--- a/components/copresence/copresence_client.cc

+++ b/components/copresence/copresence_client.cc

@@ -29,7 +29,7 @@ CopresenceClient::CopresenceClient(CopresenceClientDelegate* delegate)

rpc_handler_.reset(new RpcHandler(delegate));

// We own the RpcHandler, so it won't outlive us.

rpc_handler_->Initialize(base::Bind(&CopresenceClient::InitStepComplete,

- base::Unretained(this),

+ AsWeakPtr(),

xiyuan 2014/08/08 20:40:53 If comment at line 30 is true, this change is not

rkc 2014/08/08 21:24:37 This code will go away with the RPC handler rebase

"Copresence device registration"));

pending_init_operations_++;