Issue 453723003: Revert of SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453723003: Revert of SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. (Closed)

Created:
6 years, 4 months ago by hal.canary

Modified:
6 years, 4 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. (https://codereview.chromium.org/465823003/) Reason for revert: Mac bots are failing Original issue's description: > SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. > > Committed: https://skia.googlesource.com/skia/+/186f7b04956a1742f185a4ca69b44b52bc50e7fc TBR=reed@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/78ee93f5454c93136efff5970553ac6105950247

Created: 6 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -61 lines)			Patch
M	gyp/core.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkImage.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/image/SkImage_Raster.cpp	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	tests/CachedDecodingPixelRefTest.cpp	View	1 chunk	+0 lines, -39 lines	0 comments	Download

Total messages: 3 (0 generated)

hal.canary

Created Revert of SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.

6 years, 4 months ago (2014-08-12 16:06:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/453723003/1

6 years, 4 months ago (2014-08-12 16:07:02 UTC) #2

commit-bot: I haz the power

6 years, 4 months ago (2014-08-12 16:07:14 UTC) #3

Message was sent while issue was closed.

Change committed as 78ee93f5454c93136efff5970553ac6105950247