Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 453703002: Move ini_parser from base to chrome/common (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move ini_parser from base to chrome/common This was moved to base apparently thinking it could be shared with a media gallery thing that seems not to have panned out. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288814

Patch Set 1 #

Patch Set 2 : more #

Total comments: 1

Patch Set 3 : comments addressed #

Patch Set 4 : base:: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -299 lines) Patch
M base/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D base/ini_parser.h View 1 chunk +0 lines, -69 lines 0 comments Download
D base/ini_parser.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D base/ini_parser_unittest.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/importer/firefox_importer_utils.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
A + chrome/common/ini_parser.h View 1 2 4 chunks +7 lines, -12 lines 0 comments Download
A + chrome/common/ini_parser.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
A + chrome/common/ini_parser_unittest.cc View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/utility/media_galleries/picasa_albums_indexer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
6 years, 4 months ago (2014-08-08 00:22:35 UTC) #1
Lei Zhang
. o O (Should we make it a component?) https://codereview.chromium.org/453703002/diff/20001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): https://codereview.chromium.org/453703002/diff/20001/chrome/chrome_tests_unit.gypi#newcode1864 chrome/chrome_tests_unit.gypi:1864: ...
6 years, 4 months ago (2014-08-08 00:33:22 UTC) #2
brettw
PTAL, thanks for catching the unittest thing. Since this is only used by chrome/common, there's ...
6 years, 4 months ago (2014-08-11 16:24:20 UTC) #3
Lei Zhang
lgtm
6 years, 4 months ago (2014-08-11 18:26:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/453703002/60001
6 years, 4 months ago (2014-08-11 19:17:09 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-11 20:34:58 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 22:44:28 UTC) #7
Message was sent while issue was closed.
Change committed as 288814

Powered by Google App Engine
This is Rietveld 408576698