Chromium Code Reviews
Help | Chromium Project | Sign in
(263)

Issue 4537001: Update with new test suite, with shorter test data set. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by lzheng
Modified:
4 years, 3 months ago
Reviewers:
Scott Hess
CC:
chromium-reviews, ben+cc_chromium.org, gcasto (DO NOT USE)
Visibility:
Public.

Description

Update with new test suite, with shorter test data set. BUG=47318 TEST=safe_browsing_test green on trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66196

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 1 2 3 chunks +9 lines, -17 lines 0 comments Download
Project "None" does not have a commit queue.

Messages

Total messages: 5 (0 generated)
lzheng
With the r105 of safebrowsing test server, the test data is smaller, at the same ...
4 years, 9 months ago (2010-11-09 22:04:10 UTC) #1
Scott Hess
LGTM.
4 years, 9 months ago (2010-11-09 22:19:15 UTC) #2
lzheng
Scott: I disabled ipv6 since when using 'localhost' on windows, ipv6 will try [::1] first ...
4 years, 9 months ago (2010-11-13 06:34:14 UTC) #3
Scott Hess
LGTM. You should bug someone who knows Windows better (maybe eroman) and see if this ...
4 years, 9 months ago (2010-11-13 14:44:57 UTC) #4
lzheng
4 years, 9 months ago (2010-11-16 00:24:40 UTC) #5
Eric helped me located this problem. He is fine to have the flag here.

Thanks!

Lei

On 2010/11/13 14:44:57, shess wrote:
> LGTM.
> 
> You should bug someone who knows Windows better (maybe eroman) and see
> if this is a generally-interesting change to make for the test suite.
> Exercising the ipv6 code is useful, but exercising the same paths
> hundreds/thousands of times is redundant, especially if it adds
> timeouts.
> 
> -scott
> 
> 
> On Fri, Nov 12, 2010 at 10:34 PM,  <mailto:lzheng@chromium.org> wrote:
> > Scott:
> >
> > I disabled ipv6 since when using 'localhost' on windows, ipv6 will try [::1]
> > first and makes request slow. After ipv6 is disabled, the test takes 11secs
> > instead of 34 secs on windows. The test runs pretty stable now on trybots.
> > Let me know if this is okay with you. Otherwise, I will commit it after
> > another
> > sync.
> >
> > On 2010/11/09 22:19:15, shess wrote:
> >>
> >> LGTM.
> >
> >
> >
> > http://codereview.chromium.org/4537001/
> >
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c33a7a4