Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 453673003: [SyncFS] Promote demoted changes in default remote side backend (Closed)

Created:
6 years, 4 months ago by tzik
Modified:
6 years, 4 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Promote demoted changes in default remote side backend BUG=401853 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289135

Patch Set 1 #

Patch Set 2 : fix test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/sync_file_system/sync_file_system_service.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
tzik
PTL
6 years, 4 months ago (2014-08-08 04:57:09 UTC) #1
peria
lgtm Please fill BUG= line.
6 years, 4 months ago (2014-08-08 04:59:59 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 4 months ago (2014-08-08 05:10:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/453673003/1
6 years, 4 months ago (2014-08-08 05:13:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-08 08:58:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 09:36:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/2201) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/4209)
6 years, 4 months ago (2014-08-08 09:36:20 UTC) #7
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 4 months ago (2014-08-12 08:33:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/453673003/20001
6 years, 4 months ago (2014-08-12 08:35:31 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 10:30:41 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 12:24:35 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/5835)
6 years, 4 months ago (2014-08-12 12:24:36 UTC) #12
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 4 months ago (2014-08-12 13:31:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/453673003/20001
6 years, 4 months ago (2014-08-12 13:33:29 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-12 20:31:41 UTC) #15
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 00:38:03 UTC) #16
Message was sent while issue was closed. 
Change committed as 289135

Powered by Google App Engine
This is Rietveld 408576698