Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2619)

Unified Diff: Source/platform/graphics/GraphicsContext.cpp

Issue 453653003: [SVG] DisplayList-based patterns. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: 9 tests marked for rebaseline Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/GraphicsContext.cpp
diff --git a/Source/platform/graphics/GraphicsContext.cpp b/Source/platform/graphics/GraphicsContext.cpp
index 902e2b7c02c572b40fb3acff3692427265453676..f8a466adb2fa8e47bb3ed49f5ceb1a8b54dc343f 100644
--- a/Source/platform/graphics/GraphicsContext.cpp
+++ b/Source/platform/graphics/GraphicsContext.cpp
@@ -507,6 +507,10 @@ void GraphicsContext::beginRecording(const FloatRect& bounds)
// We want the bounds offset mapped to (0, 0), such that the display list content
// is fully contained within the SkPictureRecord's bounds.
+ // FIXME: we record this translation *in the picture*, and compensate externally in
+ // drawDisplayList(). But if the picture is passed to an unaware consumer, this info
+ // is lost. I don't think we have to record the translation, we should investigate
+ // extracting it out of the picture.
if (!toFloatSize(bounds.location()).isZero()) {
m_canvas->translate(-bounds.x(), -bounds.y());
// To avoid applying the offset repeatedly in getTotalMatrix(), we pre-apply it here.

Powered by Google App Engine
This is Rietveld 408576698