LayoutTests/svg/custom/pattern-in-defs.svg - Issue 453653003: [SVG] DisplayList-based patterns.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/pattern-in-defs.svg

Issue 453653003: [SVG] DisplayList-based patterns. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: 9 tests marked for rebaseline Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <svg xmlns="http://www.w3.org/2000/svg" width="100" height="100">	1 <svg xmlns="http://www.w3.org/2000/svg" width="100" height="100">

2 <defs>	2 <defs>

3 <pattern id="green" x="0" y="0" width="100" height="100">	3 <pattern id="green" x="0" y="0" width="100" height="100" patternUnits="userS paceOnUse">
	Erik Dahlström (inactive) 2014/08/08 08:01:02 I'm curious, why was this change needed? I'm curious, why was this change needed? f(malita) 2014/08/08 15:30:35 Before I've added tile clamping in Skia, the defau Show quoted text On 2014/08/08 08:01:02, Erik Dahlström wrote: > I'm curious, why was this change needed? Before I've added tile clamping in Skia, the default OBB units were causing an attempt to allocate some humongous tile (10000x10000) which was failing => pixel diff. With clamping in place everything works as before, but since the intent of the test is clearly to use userSpaceOnUse units I figured we might as well take the opportunity to fix it.
4 <rect x="0" y="0" width="100" height="100" fill="green"/>	4 <rect x="0" y="0" width="100" height="100" fill="green"/>

5 </pattern>	5 </pattern>

6 </defs>	6 </defs>

7 <rect x="0" y="0" width="100" height="100" fill="red" />	7 <rect x="0" y="0" width="100" height="100" fill="red" />

8 <rect x="0" y="0" width="100" height="100" fill="url(#green)" />	8 <rect x="0" y="0" width="100" height="100" fill="url(#green)" />

9 </svg>	9 </svg>

OLD	NEW