Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: ipc/mojo/ipc_message_pipe_reader.cc

Issue 453643003: IPC::ChannelMojo: Don't supress MOJO_RESULT_FAILED_PRECONDITION (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/mojo/ipc_channel_mojo_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/mojo/ipc_message_pipe_reader.cc
diff --git a/ipc/mojo/ipc_message_pipe_reader.cc b/ipc/mojo/ipc_message_pipe_reader.cc
index 91022ac7f7be7d5617beec9b67fa0b8b8dd3cc9a..b0df9976b3c2c7bef76f5abd887c0db3baf4051f 100644
--- a/ipc/mojo/ipc_message_pipe_reader.cc
+++ b/ipc/mojo/ipc_message_pipe_reader.cc
@@ -67,12 +67,12 @@ void MessagePipeReader::PipeIsReady(MojoResult wait_result) {
pipe_wait_id_ = 0;
if (wait_result != MOJO_RESULT_OK) {
- // FAILED_PRECONDITION happens when the pipe is
- // closed before the waiter is scheduled in a backend thread.
- if (wait_result != MOJO_RESULT_ABORTED &&
- wait_result != MOJO_RESULT_FAILED_PRECONDITION) {
- DLOG(WARNING) << "Pipe got error from the waiter. Closing: "
- << wait_result;
+ if (wait_result != MOJO_RESULT_ABORTED) {
viettrungluu 2014/08/08 00:36:12 This is fine, but do you ever expect to see MOJO_R
+ // FAILED_PRECONDITION happens every time the peer is dead so
+ // it isn't worth polluting the log message.
+ DLOG_IF(WARNING, wait_result != MOJO_RESULT_FAILED_PRECONDITION)
+ << "Pipe got error from the waiter. Closing: "
+ << wait_result;
OnPipeError(wait_result);
}
« no previous file with comments | « ipc/mojo/ipc_channel_mojo_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698