Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: extensions/renderer/event_bindings.cc

Issue 453613002: Implement support for <extensionoptions> embedding in WebUI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add left brace Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/event_bindings.cc
diff --git a/extensions/renderer/event_bindings.cc b/extensions/renderer/event_bindings.cc
index 948d3dedd98b305b62474127d4bd8df86d0767cd..bf89669b452807604b56c66e760657af97039485 100644
--- a/extensions/renderer/event_bindings.cc
+++ b/extensions/renderer/event_bindings.cc
@@ -210,10 +210,6 @@ void EventBindings::AttachFilteredEvent(
return;
std::string extension_id = context()->GetExtensionID();
- if (extension_id.empty()) {
- args.GetReturnValue().Set(static_cast<int32_t>(-1));
- return;
- }
scoped_ptr<base::DictionaryValue> filter;
scoped_ptr<content::V8ValueConverter> converter(
@@ -256,8 +252,6 @@ void EventBindings::DetachFilteredEvent(
bool is_manual = args[1]->BooleanValue();
std::string extension_id = context()->GetExtensionID();
- if (extension_id.empty())
- return;
int matcher_id = args[0]->Int32Value();
EventFilter& event_filter = g_event_filter.Get();
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698