Implement support for <extensionoptions> embedding in WebUI

chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"
 
 #include "base/command_line.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 271 matching lines @@
 
   // We used to limit WebView to |BLESSED_EXTENSION_CONTEXT| within platform
   // apps. An ext/app runs in a blessed extension context, if it is the active
   // extension in the current process, in other words, if it is loaded in a top
   // frame. To support webview in a non-frame extension, we have to allow
   // unblessed extension context as well.
   // Note: setting up the WebView class here, not the chrome.webview API.
   // The API will be automatically set up when first used.
   if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT ||
       context_type == extensions::Feature::UNBLESSED_EXTENSION_CONTEXT) {
     if (extension->permissions_data()->HasAPIPermission(

[not at google - send to devlin, 2014/08/12 00:08:23]

Add TODO(fsamuel): Use context->GetAvailability("webViewInternal").

[ericzeng, 2014/08/12 00:32:27]

Done.

             extensions::APIPermission::kWebView)) {
       module_system->Require("webView");
       if (extensions::GetCurrentChannel() <= chrome::VersionInfo::CHANNEL_DEV) {
         module_system->Require("webViewExperimental");
       } else {
         // TODO(asargent) We need a whitelist for webview experimental.
         // crbug.com/264852
         std::string id_hash = base::SHA1HashString(extension->id());
         std::string hexencoded_id_hash =
             base::HexEncode(id_hash.c_str(), id_hash.length());
         if (hexencoded_id_hash == "8C3741E3AF0B93B6E8E0DDD499BB0B74839EA578" ||
             hexencoded_id_hash == "E703483CEF33DEC18B4B6DD84B5C776FB9182BDB" ||
             hexencoded_id_hash == "1A26E32DE447A17CBE5E9750CDBA78F58539B39C" ||
             hexencoded_id_hash == "59048028102D7B4C681DBC7BC6CD980C3DC66DA3") {
           module_system->Require("webViewExperimental");
         }
       }
     } else {
       module_system->Require("denyWebView");
     }
   }
 
   if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT) {
     if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kEnableAppView) &&

[not at google - send to devlin, 2014/08/12 00:08:24]

Add TODO(fsamuel): Use context->GetAvailability("appViewInternal").

[ericzeng, 2014/08/12 00:32:27]

Done.

         extension->permissions_data()->HasAPIPermission(
             extensions::APIPermission::kAppView)) {
       module_system->Require("appView");
     } else {
       module_system->Require("denyAppView");
     }
   }
 
-  if (context_type == extensions::Feature::BLESSED_EXTENSION_CONTEXT &&
-      extensions::FeatureSwitch::embedded_extension_options()->IsEnabled() &&
-      extension->permissions_data()->HasAPIPermission(
-          extensions::APIPermission::kEmbeddedExtensionOptions)) {
+  if (extensions::FeatureSwitch::embedded_extension_options()->IsEnabled() &&
+      context->GetAvailability("extensionOptionsInternal").is_available()) {
     module_system->Require("extensionOptions");
   }
 }
 
 void ChromeExtensionsDispatcherDelegate::OnActiveExtensionsUpdated(
     const std::set<std::string>& extension_ids) {
   // In single-process mode, the browser process reports the active extensions.
   if (CommandLine::ForCurrentProcess()->HasSwitch(::switches::kSingleProcess))
     return;
   crash_keys::SetActiveExtensions(extension_ids);
@@ skipping 44 matching lines @@
       new extensions::PermissionSet(extensions::APIPermissionSet(),
                                     extensions::ManifestPermissionSet(),
                                     origin_set,
                                     extensions::URLPatternSet()));
 }
 
 void ChromeExtensionsDispatcherDelegate::HandleWebRequestAPIUsage(
     bool webrequest_used) {
   webrequest_used_ = webrequest_used;
 }