Implement support for <extensionoptions> embedding in WebUI

chrome/browser/guest_view/extension_options/extension_options_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/guest_view/extension_options/extension_options_guest.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
 #include "chrome/browser/guest_view/extension_options/extension_options_constants.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 46 matching lines @@
     const WebContentsCreatedCallback& callback) {
   // Get the extension's base URL.
   std::string extension_id;
   create_params.GetString(extensionoptions::kExtensionId, &extension_id);
 
   if (!extensions::Extension::IdIsValid(extension_id)) {
     callback.Run(NULL);
     return;
   }
 
-  if (extension_id != embedder_extension_id) {
-    callback.Run(NULL);
-    return;
+  if (!embedder_extension_id.empty()) {
+    if (extension_id != embedder_extension_id) {

[not at google - send to devlin, 2014/08/12 00:08:23]

how about:

if (extensions::Extension::IdIsValid(embedder_extension_id) &&
    extension_id != embedder_extension_id) {
  // Extensions cannot embed other extensions' options pages.
  callback.Run(NULL);
  return;
}

[ericzeng, 2014/08/12 00:32:26]

Done.

+      callback.Run(NULL);
+      return;
+    }
   }
 
   GURL extension_url =
       extensions::Extension::GetBaseURLFromExtensionId(extension_id);
   if (!extension_url.is_valid()) {
     callback.Run(NULL);
     return;
   }
 
   // Get the options page URL for later use.
@@ skipping 67 matching lines @@
   DispatchEventToEmbedder(new GuestViewBase::Event(
       extension_options_internal::OnSizeChanged::kEventName, args.Pass()));
 }
 
 bool ExtensionOptionsGuest::IsAutoSizeSupported() const {
   return true;
 }
 
 void ExtensionOptionsGuest::SetUpAutoSize() {
   // Read the autosize parameters passed in from the embedder.
-  bool auto_size_enabled;
+  bool auto_size_enabled = false;
   extra_params()->GetBoolean(extensionoptions::kAttributeAutoSize,
                              &auto_size_enabled);
 
   int max_height = 0;
   int max_width = 0;
   extra_params()->GetInteger(extensionoptions::kAttributeMaxHeight,
                              &max_height);
   extra_params()->GetInteger(extensionoptions::kAttributeMaxWidth, &max_width);
 
   int min_height = 0;
   int min_width = 0;
   extra_params()->GetInteger(extensionoptions::kAttributeMinHeight,
                              &min_height);
   extra_params()->GetInteger(extensionoptions::kAttributeMinWidth, &min_width);
 
   // Call SetAutoSize to apply all the appropriate validation and clipping of
   // values.
   SetAutoSize(
       true, gfx::Size(min_width, min_height), gfx::Size(max_width, max_height));
 }