Implement support for <extensionoptions> embedding in WebUI

extensions/renderer/event_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/event_bindings.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 192 matching lines @@
   CHECK(args[0]->IsString());
   CHECK(args[1]->IsObject());
 
   std::string event_name = *v8::String::Utf8Value(args[0]);
 
   // This method throws an exception if it returns false.
   if (!dispatcher_->CheckContextAccessToExtensionAPI(event_name, context()))
     return;
 
   std::string extension_id = context()->GetExtensionID();
-  if (extension_id.empty()) {
+  if (extension_id.empty() &&
+      context()->context_type() != Feature::Context::WEBUI_CONTEXT) {

[not at google - send to devlin, 2014/08/07 23:06:03]

I'm surprised any of the filtered event logic works, I never implemented the
dispatch-to-URL logic for filtered events:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

just non-filtered events.

in any case, just delete this check rather than adding the WEBUI_CONTEXT part.

[ericzeng, 2014/08/08 00:23:47]

Done. Are you absolutely sure that the check isn't necessary?

[not at google - send to devlin, 2014/08/08 14:08:15]

yes, it will get caught up on the browser.

     args.GetReturnValue().Set(static_cast<int32_t>(-1));
     return;
   }
 
   scoped_ptr<base::DictionaryValue> filter;
   scoped_ptr<content::V8ValueConverter> converter(
       content::V8ValueConverter::create());
 
   base::DictionaryValue* filter_dict = NULL;
   base::Value* filter_value =
@@ skipping 25 matching lines @@
 }
 
 void EventBindings::DetachFilteredEvent(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   CHECK_EQ(2, args.Length());
   CHECK(args[0]->IsInt32());
   CHECK(args[1]->IsBoolean());
   bool is_manual = args[1]->BooleanValue();
 
   std::string extension_id = context()->GetExtensionID();
-  if (extension_id.empty())
+  if (extension_id.empty() &&
+      context()->context_type() != Feature::Context::WEBUI_CONTEXT) {

[not at google - send to devlin, 2014/08/07 23:06:03]

likewise

[ericzeng, 2014/08/08 00:23:47]

Done.

+    args.GetReturnValue().Set(static_cast<int32_t>(-1));
     return;
+  }
 
   int matcher_id = args[0]->Int32Value();
   EventFilter& event_filter = g_event_filter.Get();
   EventMatcher* event_matcher = event_filter.GetEventMatcher(matcher_id);
 
   const std::string& event_name = event_filter.GetEventName(matcher_id);
 
   // Only send IPCs the last time a filter gets removed.
   if (RemoveFilter(event_name, extension_id, event_matcher->value())) {
     bool lazy = is_manual && IsLazyBackgroundPage(context()->GetRenderView(),
@@ skipping 29 matching lines @@
 }
 
 scoped_ptr<EventMatcher> EventBindings::ParseEventMatcher(
     base::DictionaryValue* filter_dict) {
   return scoped_ptr<EventMatcher>(new EventMatcher(
       scoped_ptr<base::DictionaryValue>(filter_dict->DeepCopy()),
       context()->GetRenderView()->GetRoutingID()));
 }
 
 }  // namespace extensions