Implement support for <extensionoptions> embedding in WebUI

chrome/renderer/resources/extensions/extension_options.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var DocumentNatives = requireNative('document_natives');
 var ExtensionOptionsEvents =
     require('extensionOptionsEvents').ExtensionOptionsEvents;
 var GuestViewInternal =
     require('binding').Binding.create('guestViewInternal').generate();
 var IdGenerator = requireNative('id_generator');
@@ skipping 39 matching lines @@
 ExtensionOptionsInternal.prototype.createBrowserPluginNode = function() {
   var browserPluginNode = new ExtensionOptionsInternal.BrowserPlugin();
   privates(browserPluginNode).internal = this;
   return browserPluginNode;
 };
 
 ExtensionOptionsInternal.prototype.createGuest = function() {
   var params = {
     'extensionId': this.extensionId,
   };
+
   GuestViewInternal.createGuest(
       'extensionoptions',
       params,
       function(instanceId) {
         if (instanceId == 0) {
           this.initCalled = false;
         } else {
           this.attachWindow(instanceId);
           GuestViewInternal.setAutoSize(this.instanceId, {
             'enableAutoSize':
@@ skipping 52 matching lines @@
       }
     });
   }
 };
 
 ExtensionOptionsInternal.prototype.init = function() {
   if (this.initCalled)
     return;
 
   this.initCalled = true;
+
   this.browserPluginNode = this.createBrowserPluginNode();
+
   var shadowRoot = this.extensionoptionsNode.createShadowRoot();
   shadowRoot.appendChild(this.browserPluginNode);
   this.createGuest();
 };
 
 ExtensionOptionsInternal.prototype.onSizeChanged = function(width, height) {
   this.browserPluginNode.style.width = width + 'px';
   this.browserPluginNode.style.height = height + 'px';
 };
 
 ExtensionOptionsInternal.prototype.parseExtensionAttribute = function() {
   if (this.extensionoptionsNode.hasAttribute('extension')) {
-    var extensionId = this.extensionoptionsNode.getAttribute('extension');
-    // Only allow extensions to embed their own options page (if it has one).

[not at google - send to devlin, 2014/08/07 23:06:03]

was this security check important? because now there is no check, obviously.

[ericzeng, 2014/08/08 00:23:47]

No, the checks will be unnecessary when I rebase onto this CL:
https://codereview.chromium.org/429763002/. The CL handles all of the invalid
cases at the C++ level in ExtensionOptionsGuest.

The change was a little premature but I had to get rid of the checks so that it
doesn't depend on being inside an extension context.

-    if (chrome.runtime.id == extensionId &&
-        chrome.runtime.getManifest().hasOwnProperty('options_page')) {
-      this.extensionId  = extensionId;
-      return true;
-    }
+    this.extensionId = this.extensionoptionsNode.getAttribute('extension');
+    return true;
   }
   return false;
 };
 
 // Adds an 'on<event>' property on the view, which can be used to set/unset
 // an event handler.
 ExtensionOptionsInternal.prototype.setupEventProperty = function(eventName) {
   var propertyName = 'on' + eventName.toLowerCase();
   var self = this;
   var extensionoptionsNode = this.extensionoptionsNode;
@@ skipping 109 matching lines @@
 
 var useCapture = true;
 window.addEventListener('readystatechange', function listener(event) {
   if (document.readyState == 'loading')
     return;
 
   registerBrowserPluginElement();
   registerExtensionOptionsElement();
   window.removeEventListener(event.type, listener, useCapture);
 }, useCapture);