Implement support for <extensionoptions> embedding in WebUI

chrome/browser/extensions/extension_webui_apitest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/common/api/test.h"
 #include "extensions/common/extension.h"
+#include "extensions/common/feature_switch.h"
+#include "extensions/common/switches.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace extensions {
 
 namespace OnMessage = core_api::test::OnMessage;
 
 namespace {
 
 void FindFrame(const GURL& url,
                content::RenderFrameHost** out,
@@ skipping 70 matching lines @@
         browser()->tab_strip_model()->GetActiveWebContents();
 
     if (active_web_contents->GetLastCommittedURL() == frame_url)
       return active_web_contents->GetMainFrame();
 
     content::RenderFrameHost* frame_host = NULL;
     active_web_contents->ForEachFrame(
         base::Bind(&FindFrame, frame_url, &frame_host));
     return frame_host;
   }
+
+  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
+    // Need to add a command line flag as well as a FeatureSwitch because the
+    // FeatureSwitch is not copied over to the renderer process from the
+    // browser process.
+    command_line->AppendSwitch(
+        extensions::switches::kEnableEmbeddedExtensionOptions);
+    ExtensionApiTest::SetUpCommandLine(command_line);
+  }
 };
 
 IN_PROC_BROWSER_TEST_F(ExtensionWebUITest, SanityCheckAvailableAPIs) {
   ASSERT_TRUE(RunTestOnExtensions("sanity_check_available_apis.js"));
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionWebUITest, SanityCheckUnavailableAPIs) {
   ASSERT_TRUE(RunTestOnAbout("sanity_check_available_apis.js"));
 }
 
@@ skipping 39 matching lines @@
   ASSERT_TRUE(RunTestOnExtensions("runtime_last_error.js"));
 
   ASSERT_TRUE(listener->WaitUntilSatisfied());
   listener->ReplyWithError("unknown host");
 
   listener.reset(new ExtensionTestMessageListener(false));
   ASSERT_TRUE(listener->WaitUntilSatisfied());
   EXPECT_EQ("true", listener->message());
 }
 
+IN_PROC_BROWSER_TEST_F(ExtensionWebUITest, CanEmbedExtensionOptions) {
+  FeatureSwitch::ScopedOverride enable_options(
+      FeatureSwitch::embedded_extension_options(), true);

[not at google - send to devlin, 2014/08/07 23:06:02]

might as well do this in a member variable as well, since you're overriding the
command line. odd to have one but not the other?

[ericzeng, 2014/08/08 00:23:46]

Done.

+
+  scoped_ptr<ExtensionTestMessageListener> listener(
+      new ExtensionTestMessageListener("ready", true));
+
+  const Extension* extension = InstallExtension(
+      test_data_dir_.AppendASCII("extension_options").AppendASCII("embed_self"),
+      1);
+  ASSERT_TRUE(extension);
+
+  ASSERT_TRUE(RunTestOnExtensions("can_embed_extension_options.js"));
+
+  ASSERT_TRUE(listener->WaitUntilSatisfied());
+  listener->Reply(extension->id());
+  listener.reset(new ExtensionTestMessageListener("guest loaded", false));
+  ASSERT_TRUE(listener->WaitUntilSatisfied());
+}
+
 }  // namespace
 
 }  // namespace extensions