Implement support for <extensionoptions> embedding in WebUI

chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/guest_view/guest_view_internal_api.h"
 
 #include "chrome/browser/guest_view/guest_view_base.h"
 #include "chrome/browser/guest_view/guest_view_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/guest_view_internal.h"
@@ skipping 15 matching lines @@
 
   base::DictionaryValue* create_params;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(1, &create_params));
 
   GuestViewManager* guest_view_manager =
       GuestViewManager::FromBrowserContext(browser_context());
 
   GuestViewManager::WebContentsCreatedCallback callback =
       base::Bind(&GuestViewInternalCreateGuestFunction::CreateGuestCallback,
                  this);
+
+  // If this the guest is an <extensionoptions> to be embedded in a WebUI, then
+  // there is no extension, and extension() will be null. Use an empty string

[not at google - send to devlin, 2014/08/07 23:06:02]

this shouldn't be necessary after https://codereview.chromium.org/426593007/
goes in

[ericzeng, 2014/08/08 00:23:46]

I'm not sure if that's the case. ExtensionFunction::extension_id() gets the id
by calling extension_->id(), but extension_ will be NULL if I embed my guest
view in WebUI, which causes it to crash in here. Did you make any modifications
to ExtensionFunction elsewhere?

[not at google - send to devlin, 2014/08/08 14:08:15]

ah you're right, my bad sorry.

1 last nit: the last sentence isn't needed.

+  // instead.
+  std::string embedder_extension_id = "";

[Fady Samuel, 2014/08/07 23:09:29]

no need for initializer.

[ericzeng, 2014/08/08 00:23:46]

Done.

+  if (extension()) {

[Fady Samuel, 2014/08/07 23:09:29]

No need for braces.

[ericzeng, 2014/08/08 00:23:46]

Done.

+    embedder_extension_id = extension_id();
+  }
+
   guest_view_manager->CreateGuest(view_type,
-                                  extension_id(),
+                                  embedder_extension_id,
                                   render_view_host()->GetProcess()->GetID(),
                                   *create_params,
                                   callback);
 
   return true;
 }
 
 void GuestViewInternalCreateGuestFunction::CreateGuestCallback(
     content::WebContents* guest_web_contents) {
   int guest_instance_id = 0;
@@ skipping 24 matching lines @@
   guest->SetAutoSize(params->params.enable_auto_size,
                      gfx::Size(params->params.min.width,
                                params->params.min.height),
                      gfx::Size(params->params.max.width,
                                params->params.max.height));
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions