Issue 453573003: views: Make the minimum size of the content setting bubble wider.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453573003: views: Make the minimum size of the content setting bubble wider. (Closed)

Created:
6 years, 4 months ago by Elliot Glaysher

Modified:
6 years, 4 months ago

Reviewers:
msw

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

views: Make the minimum size of the content setting bubble wider. I can't actually reproduce the bug as described by the reporter; this is a blind change that expands the minimum width which should theoretically fix the problem though. BUG=400144 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288253

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/content_setting_bubble_contents.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

msw

I couldn't find any obvious defect in MenuButton... Shrug, seems like a safe/simple workaround; lgtm.

6 years, 4 months ago (2014-08-07 20:36:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/453573003/1

6 years, 4 months ago (2014-08-07 20:46:09 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-08 01:34:55 UTC) #5

Message was sent while issue was closed.

Change committed as 288253

Expand Messages | Collapse Messages