Issue 453573002: Remove |kAltInstantURLPath| from search.cc and retain the default Instant search base url path...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453573002: Remove |kAltInstantURLPath| from search.cc and retain the default Instant search base url path... (Closed)

Created:
6 years, 4 months ago by kmadhusu

Modified:
6 years, 4 months ago

Reviewers:
samarth

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove |kAltInstantURLPath| from search.cc and retain the default Instant search base url path when the |kUseAltInstantURL| flag is enabled. BUG=382694 TEST=Run chrome with the following field trial flag and observe the Instant search base page url. --force-fieldtrials="EmbeddedSearch/Group1 use_alternate_instant_url:1 /" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289046

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/search/search.cc	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
	M	chrome/browser/search/search_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/453573002/20001

6 years, 4 months ago (2014-08-12 16:27:42 UTC) #4

Message was sent while issue was closed.

Change committed as 289046

Expand Messages | Collapse Messages