Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 453523002: Fix shutdown assertions in WebViewImpl (Closed)

Created:
6 years, 4 months ago by enne (OOO)
Modified:
6 years, 4 months ago
Reviewers:
jamesr, chrishtr
CC:
blink-reviews, danakj
Project:
blink
Visibility:
Public.

Description

Fix shutdown assertions in WebViewImpl It's possible for some calls (e.g. WebViewImpl::layout) to try to initialize compositing after shutdown. This just moves an early out earlier so that it does not assert when this happens. This is a small band-aid fix to stop this assert from happening, rather than the larger fix of trying to stop all the cases where this happen or refactoring WebViewImpl to not have this awkwardness int he first place. R=chrishtr@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M Source/web/WebViewImpl.cpp View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
enne (OOO)
6 years, 4 months ago (2014-08-07 19:02:37 UTC) #1
chrishtr
lgtm
6 years, 4 months ago (2014-08-07 20:21:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/453523002/1
6 years, 4 months ago (2014-08-07 20:22:44 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-07 22:04:16 UTC) #4
enne (OOO)
+jamesr for Source/web OWNERZ
6 years, 4 months ago (2014-08-07 22:10:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 22:33:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12171)
6 years, 4 months ago (2014-08-07 22:33:45 UTC) #7
jamesr
lgtm
6 years, 4 months ago (2014-08-07 22:43:10 UTC) #8
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 4 months ago (2014-08-08 19:19:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/453523002/1
6 years, 4 months ago (2014-08-08 19:19:39 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 19:39:24 UTC) #11
Message was sent while issue was closed.
Change committed as 179860

Powered by Google App Engine
This is Rietveld 408576698