tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp - Issue 453513004: Roll Clang 214024:216630 (+216684) and switch to CMake

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 453513004: Roll Clang 214024:216630 (+216684) and switch to CMake (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase, fix blink-gc plugin flags, disable -Wundefined-bool-conversion while testing Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

diff --git a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

index 3791a0f820ae9adb6d710bf5b82f2cbfc0265fe3..dc58d59811c2b52ef5a1a34a8c2e8d0f4c91868d 100644

--- a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

+++ b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

@@ -1751,9 +1751,10 @@ class BlinkGCPluginAction : public PluginASTAction {

protected:

// Overridden from PluginASTAction:

- virtual ASTConsumer* CreateASTConsumer(CompilerInstance& instance,

- llvm::StringRef ref) {

- return new BlinkGCPluginConsumer(instance, options_);

+ virtual std::unique_ptr<ASTConsumer> CreateASTConsumer(

+ CompilerInstance& instance,

+ llvm::StringRef ref) {

+ return llvm::make_unique<BlinkGCPluginConsumer>(instance, options_);

}

virtual bool ParseArgs(const CompilerInstance& instance,