Source/core/html/shadow/MediaControls.h - Issue 453493002: Improve detection of touch events when hiding media controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.h

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls

Patch Set: Added multimodal tests and NotFromInput synthetic type. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/events/MouseRelatedEvent.h ('K') | « Source/core/events/WheelEvent.cpp ('k') | Source/core/html/shadow/MediaControls.cpp » ('j') | Source/core/html/shadow/MediaControls.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/shadow/MediaControls.h

diff --git a/Source/core/html/shadow/MediaControls.h b/Source/core/html/shadow/MediaControls.h

index a08c21b5b333373e25031dde4f8e693ea04cb610..8c6a81ceb098e8113d4878f6b669019bf2da16d3 100644

--- a/Source/core/html/shadow/MediaControls.h

+++ b/Source/core/html/shadow/MediaControls.h

@@ -76,6 +76,7 @@ private:

bool initializeControls();

void makeOpaque();

+ void makeOpaqueIfNeeded(Event*);

void makeTransparent();

void updatePlayState();

@@ -128,6 +129,7 @@ private:

Timer<MediaControls> m_hideMediaControlsTimer;

bool m_isMouseOverControls : 1;

bool m_isPausedForScrubbing : 1;

+ bool m_wasLastEventTouch : 1;

};

DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());

« Source/core/events/MouseRelatedEvent.h ('K') | « Source/core/events/WheelEvent.cpp ('k') | Source/core/html/shadow/MediaControls.cpp » ('j') | Source/core/html/shadow/MediaControls.cpp » ('J')