Source/core/page/EventHandler.h - Issue 453493002: Improve detection of touch events when hiding media controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.h

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls

Patch Set: Cannot use isSimulated, so define derivesFromTouch Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventHandler.h

diff --git a/Source/core/page/EventHandler.h b/Source/core/page/EventHandler.h

index a7683bd0605e27632b237dc65282eaded3c20d74..9f40525128371c00d8fececc4f5e3b82480bf909 100644

--- a/Source/core/page/EventHandler.h

+++ b/Source/core/page/EventHandler.h

@@ -269,11 +269,11 @@ private:

void invalidateClick();

- void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&, bool fireMouseOverOut);

+ void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&, bool fireMouseOverOut, bool derivesFromTouch);

MouseEventWithHitTestResults prepareMouseEvent(const HitTestRequest&, const PlatformMouseEvent&);

- bool dispatchMouseEvent(const AtomicString& eventType, Node* target, int clickCount, const PlatformMouseEvent&, bool setUnder);

+ bool dispatchMouseEvent(const AtomicString& eventType, Node* target, int clickCount, const PlatformMouseEvent&, bool setUnder, bool derivesFromTouch);

bool dispatchDragEvent(const AtomicString& eventType, Node* target, const PlatformMouseEvent&, DataTransfer*);

void clearDragDataTransfer();

« Source/core/events/MouseEvent.h ('K') | « Source/core/html/shadow/MediaControls.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | Source/core/page/EventHandler.cpp » ('J')