Source/core/events/WheelEvent.cpp - Issue 453493002: Improve detection of touch events when hiding media controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/WheelEvent.cpp

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls

Patch Set: Cannot use isSimulated, so define derivesFromTouch Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/events/WheelEvent.cpp

diff --git a/Source/core/events/WheelEvent.cpp b/Source/core/events/WheelEvent.cpp

index 501b7691db31fdc5f8774f71feff5802670b3bed..e5605da276f5fa5db01fd2ca9d988ba5a7c80fc7 100644

--- a/Source/core/events/WheelEvent.cpp

+++ b/Source/core/events/WheelEvent.cpp

@@ -62,11 +62,9 @@ WheelEvent::WheelEvent(const AtomicString& type, const WheelEventInit& initializ

WheelEvent::WheelEvent(const FloatPoint& wheelTicks, const FloatPoint& rawDelta, unsigned deltaMode,

PassRefPtrWillBeRawPtr<AbstractView> view, const IntPoint& screenLocation, const IntPoint& pageLocation,

bool ctrlKey, bool altKey, bool shiftKey, bool metaKey)

- : MouseEvent(EventTypeNames::wheel,

- true, true, view, 0, screenLocation.x(), screenLocation.y(),

- pageLocation.x(), pageLocation.y(),

- 0, 0,

- ctrlKey, altKey, shiftKey, metaKey, 0, nullptr, nullptr, false)

+ : MouseEvent(EventTypeNames::wheel, true, true, view, 0, screenLocation.x(), screenLocation.y(),

+ pageLocation.x(), pageLocation.y(), 0, 0, ctrlKey, altKey, shiftKey, metaKey, 0, nullptr,

+ nullptr, false, false)

, m_wheelDelta(wheelTicks.x() * TickMultiplier, wheelTicks.y() * TickMultiplier)

, m_deltaX(-rawDelta.x())

, m_deltaY(-rawDelta.y())

« Source/core/events/MouseEvent.h ('K') | « Source/core/events/MouseRelatedEvent.cpp ('k') | Source/core/html/shadow/MediaControls.h » ('j') | Source/core/page/EventHandler.cpp » ('J')