Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: Source/core/events/MouseRelatedEvent.h

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls
Patch Set: Revert Patch Set 8 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/events/MouseEvent.cpp ('k') | Source/core/events/WheelEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/MouseRelatedEvent.h
diff --git a/Source/core/events/MouseRelatedEvent.h b/Source/core/events/MouseRelatedEvent.h
index 21dc6a54cc78b941ae8cf5720f8c399da3a3cab4..f14f7961213dc2e4b4cb697d844031857ad5337a 100644
--- a/Source/core/events/MouseRelatedEvent.h
+++ b/Source/core/events/MouseRelatedEvent.h
@@ -46,6 +46,9 @@ namespace blink {
virtual int layerY() OVERRIDE FINAL;
int offsetX();
int offsetY();
+ // FIXME: rename isSimulated to fromKeyboard() and replace m_isSimulated with a new value
+ // in PlatformMouseEvent::SyntheticEventType. isSimulated() is only true for synthetic
+ // mouse events that derive from keyboard input, which do not have a position.
bool isSimulated() const { return m_isSimulated; }
virtual int pageX() const OVERRIDE FINAL;
virtual int pageY() const OVERRIDE FINAL;
@@ -61,10 +64,10 @@ namespace blink {
protected:
MouseRelatedEvent();
- MouseRelatedEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtrWillBeRawPtr<AbstractView>,
- int detail, const IntPoint& screenLocation, const IntPoint& windowLocation,
- const IntPoint& movementDelta,
- bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, bool isSimulated = false);
+ MouseRelatedEvent(const AtomicString& type, bool canBubble, bool cancelable,
+ PassRefPtrWillBeRawPtr<AbstractView>, int detail, const IntPoint& screenLocation,
+ const IntPoint& windowLocation, const IntPoint& movementDelta, bool ctrlKey, bool altKey,
+ bool shiftKey, bool metaKey, bool isSimulated = false);
void initCoordinates();
void initCoordinates(const LayoutPoint& clientLocation);
« no previous file with comments | « Source/core/events/MouseEvent.cpp ('k') | Source/core/events/WheelEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698