LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html - Issue 453493002: Improve detection of touch events when hiding media controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

Issue 453493002: Improve detection of touch events when hiding media controls. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@autoHideControls

Patch Set: Revert Patch Set 8 Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/video-controls-hide-after-touch-on-control.html ('k') | LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

diff --git a/LayoutTests/media/video-controls-always-visible-when-control-hovered.html b/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

similarity index 60%

copy from LayoutTests/media/video-controls-always-visible-when-control-hovered.html

copy to LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

index 68162418d20aad1b36112dd10f7aec668bd6bc40..56179954bc7899d7b894114e9c53917e48fc9d2a 100644

--- a/LayoutTests/media/video-controls-always-visible-when-control-hovered.html

+++ b/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html

@@ -20,29 +20,28 @@ function runTest()

if (!window.testRunner)

return;

- // Click the play button.

- var playCoords = mediaControlsButtonCoordinates(video, "play-button");

- var clickX = playCoords[0];

- var clickY = playCoords[1];

- eventSender.mouseMoveTo(clickX, clickY);

- eventSender.mouseDown();

- eventSender.mouseUp();

+ // Tap (touch input) the play button.

+ var coords = mediaControlsButtonCoordinates(video, "play-button");

+ eventSender.gestureTapDown(coords[0], coords[1]);

+ eventSender.gestureShowPress(coords[0], coords[1]);

+ eventSender.gestureTap(coords[0], coords[1]);

testExpected("video.paused", false);

+ // And then hover the control with the mouse.

+ eventSender.mouseMoveTo(coords[0], coords[1]);

+ // And the controls should remain visible.

runAfterHideMediaControlsTimerFired(function()

{

controls = mediaControlsButton(video, "panel");

testExpected("getComputedStyle(controls).opacity", 1);

- consoleWrite("");

endTest();

}, video);

}

</script>

<body>

- Test video element control visibility after click on control. After the click

- the mouse does not move, so the control is still hovered and it should

- remain visible.

+ Test video element control visibility with multimodal input. The controls

+ should remain visible if the last input event was a mouse move over them.

This test only runs in DRT!