Improve detection of touch events when hiding media controls.

Source/platform/PlatformMouseEvent.h

 /*
  * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 19 matching lines @@
 #include "platform/geometry/IntPoint.h"
 
 namespace blink {
 
 // These button numbers match the ones used in the DOM API, 0 through 2, except for NoButton which isn't specified.
 enum MouseButton { NoButton = -1, LeftButton, MiddleButton, RightButton };
 
 class PlatformMouseEvent : public PlatformEvent {
 public:
     enum SyntheticEventType {
-        NotFromTouch,
-        FromTouch,
+        NotSyntheticOrIndistinguishable, // Real mouse input events or synthetic events that behave just like real events

[Rick Byers, 2014/08/22 18:11:13]

nit: maybe put these comments on the line above the value - we don't want to
discourage long comments here, if we need multiple lines that's fine.

[Rick Byers, 2014/08/22 18:11:13]

nit: this name is a bit of a mouthful.  I like that you're explicit that they
may still be synthetic though.  Maybe "RealOrIndistinguishable" would be a
little clearer?

[Ignacio Solla, 2014/08/26 13:40:53]

Done.

[Ignacio Solla, 2014/08/26 13:40:53]

I agree, it is a mouthful, I've changed it now to RealOrIndistinguishable.

FYI, I was on the verge, but had decided to use not synthetic because:
- synthetic is a more precise term than real
- one could argue that synthetic events are also real.

+        FromTouch, // Mouse events derived from touch input
+        NotFromInput, // Blink can generate fake mouse events after scrolling or re-layout, see for example EventHandler::dispatchFakeMouseMoveEventSoon
     };
 
     PlatformMouseEvent()
         : PlatformEvent(PlatformEvent::MouseMoved)
         , m_button(NoButton)
         , m_clickCount(0)
-        , m_synthesized(NotFromTouch)
+        , m_synthesized(NotSyntheticOrIndistinguishable)
         , m_modifierFlags(0)
     {
     }
 
     PlatformMouseEvent(const IntPoint& position, const IntPoint& globalPosition, MouseButton button, PlatformEvent::Type type, int clickCount, Modifiers modifiers, double timestamp)
         : PlatformEvent(type, modifiers, timestamp)
         , m_position(position)
         , m_globalPosition(globalPosition)
         , m_button(button)
         , m_clickCount(clickCount)
-        , m_synthesized(NotFromTouch)
+        , m_synthesized(NotSyntheticOrIndistinguishable)
         , m_modifierFlags(0)
     {
     }
 
     PlatformMouseEvent(const IntPoint& position, const IntPoint& globalPosition, MouseButton button, PlatformEvent::Type type, int clickCount, Modifiers modifiers, SyntheticEventType synthesized, double timestamp)
         : PlatformEvent(type, modifiers, timestamp)
         , m_position(position)
         , m_globalPosition(globalPosition)
         , m_button(button)
         , m_clickCount(clickCount)
         , m_synthesized(synthesized)
         , m_modifierFlags(0)
     {
     }
 
-    PlatformMouseEvent(const IntPoint& position, const IntPoint& globalPosition, MouseButton button, PlatformEvent::Type type, int clickCount, bool shiftKey, bool ctrlKey, bool altKey, bool metaKey, double timestamp)
+    PlatformMouseEvent(const IntPoint& position, const IntPoint& globalPosition, MouseButton button, PlatformEvent::Type type, int clickCount, bool shiftKey, bool ctrlKey, bool altKey, bool metaKey, double timestamp, SyntheticEventType synthesized = NotSyntheticOrIndistinguishable)

[Rick Byers, 2014/08/22 18:11:13]

I think we should try to keep the parameter order consistent (synthesized comes
before timestamp in the above version).  We also tend to avoid default argument
values (although I don't think they're prohibited outright like in the chromium
style guide).  I guess that means either add but-yet-another overload, or update
the handful of callers (eclipse finds 16 for me including tests).

[Ignacio Solla, 2014/08/26 13:40:53]

Done. 

Added a non-optional arg and updated all callers.

[Rick Byers, 2014/08/26 15:25:46]

Thank you!

[Ignacio Solla, 2014/08/26 17:30:42]

Acknowledged.

         : PlatformEvent(type, shiftKey, ctrlKey, altKey, metaKey, timestamp)
         , m_position(position)
         , m_globalPosition(globalPosition)
         , m_button(button)
         , m_clickCount(clickCount)
-        , m_synthesized(NotFromTouch)
+        , m_synthesized(synthesized)
         , m_modifierFlags(0)
     {
     }
 
     const IntPoint& position() const { return m_position; }
     const IntPoint& globalPosition() const { return m_globalPosition; }
     const IntPoint& movementDelta() const { return m_movementDelta; }
 
     MouseButton button() const { return m_button; }
     int clickCount() const { return m_clickCount; }
     unsigned modifierFlags() const { return m_modifierFlags; }
     bool fromTouch() const { return m_synthesized == FromTouch; }
+    SyntheticEventType syntheticEventType() const { return m_synthesized; }
 
 protected:
     IntPoint m_position;
     IntPoint m_globalPosition;
     IntPoint m_movementDelta;
     MouseButton m_button;
     int m_clickCount;
     SyntheticEventType m_synthesized;
     unsigned m_modifierFlags;
 };
 
 } // namespace blink
 
 #endif // PlatformMouseEvent_h