Improve detection of touch events when hiding media controls.

Source/core/events/MouseEvent.h

 /*
  * Copyright (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2001 Tobias Anton (anton@stud.fbi.fh-darmstadt.de)
  * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 41 matching lines @@
 public:
     static PassRefPtrWillBeRawPtr<MouseEvent> create()
     {
         return adoptRefWillBeNoop(new MouseEvent);
     }
 
     static PassRefPtrWillBeRawPtr<MouseEvent> create(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtrWillBeRawPtr<AbstractView>,
         int detail, int screenX, int screenY, int pageX, int pageY,
         int movementX, int movementY,
         bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, unsigned short button,
-        PassRefPtrWillBeRawPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<DataTransfer>, bool isSimulated = false);
+        PassRefPtrWillBeRawPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<DataTransfer>,
+        bool isSimulated = false, PlatformMouseEvent::SyntheticEventType = PlatformMouseEvent::NotFromTouch);

[Rick Byers, 2014/08/20 23:32:56]

Re-using the PlatformMouseEvent::SyntheticEventType enum is fine with me.  As
far as I'm concerned the platform/core abstraction layer around events isn't
worth the extra complexity.

I looked into the isSimulated stuff.  Looks like it's used just for
Element.dispatchSimulatedClick.  I don't understand though why it isn't just a
virtual method that results false but is overriden by SimulatedMouseEvent.

I think having both "simulated" and "synthetic" is a little confusing.  Ideally
we'd collapse them into the enum and add another value called "simulated" that
is defined not to carry any position information (that's really what makes these
events special).  If you don't want to do that refactoring now, feel free to add
a FIXME and comment somewhere that at least describes the difference between
"simulated" and "synthetic".

[Ignacio Solla, 2014/08/21 17:30:14]

Yes, I completely agree that isSimulated should be collapse into the
SyntheticEventType enum. I have added the FIXME and filed crbug/405990

 
     static PassRefPtrWillBeRawPtr<MouseEvent> create(const AtomicString& eventType, PassRefPtrWillBeRawPtr<AbstractView>, const PlatformMouseEvent&, int detail, PassRefPtrWillBeRawPtr<Node> relatedTarget);
 
     static PassRefPtrWillBeRawPtr<MouseEvent> create(const AtomicString& eventType, const MouseEventInit&);
 
     virtual ~MouseEvent();
 
     void initMouseEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtrWillBeRawPtr<AbstractView>,
         int detail, int screenX, int screenY, int clientX, int clientY,
         bool ctrlKey, bool altKey, bool shiftKey, bool metaKey,
@@ skipping 17 matching lines @@
     virtual bool isDragEvent() const OVERRIDE FINAL;
     virtual int which() const OVERRIDE FINAL;
 
     virtual void trace(Visitor*) OVERRIDE;
 
 protected:
     MouseEvent(const AtomicString& type, bool canBubble, bool cancelable, PassRefPtrWillBeRawPtr<AbstractView>,
         int detail, int screenX, int screenY, int pageX, int pageY,
         int movementX, int movementY,
         bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, unsigned short button,
-        PassRefPtrWillBeRawPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<DataTransfer>, bool isSimulated);
+        PassRefPtrWillBeRawPtr<EventTarget> relatedTarget, PassRefPtrWillBeRawPtr<DataTransfer>,
+        bool isSimulated, PlatformMouseEvent::SyntheticEventType);
 
     MouseEvent(const AtomicString& type, const MouseEventInit&);
 
     MouseEvent();
 
 private:
     unsigned short m_button;
     bool m_buttonDown;
     RefPtrWillBeMember<EventTarget> m_relatedTarget;
     RefPtrWillBeMember<DataTransfer> m_dataTransfer;
@@ skipping 22 matching lines @@
     virtual bool dispatchEvent(EventDispatcher*) const OVERRIDE;
     bool isSyntheticMouseEvent() const { return m_mouseEventType == SyntheticMouseEvent; }
     MouseEventType m_mouseEventType;
 };
 
 DEFINE_EVENT_TYPE_CASTS(MouseEvent);
 
 } // namespace blink
 
 #endif // MouseEvent_h