Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: LayoutTests/http/tests/media/media-source/mediasource-remove.html

Issue 453473002: Change SourceBuffer.remove() end parameter to unrestricted double. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/media/media-source/mediasource-remove.html
diff --git a/LayoutTests/http/tests/media/media-source/mediasource-remove.html b/LayoutTests/http/tests/media/media-source/mediasource-remove.html
index 6b7ab6cae5e682ddb09e98b776b3d34701e57e14..f41d455a9f51e50a6e767727a1413f567bb3a424 100644
--- a/LayoutTests/http/tests/media/media-source/mediasource-remove.html
+++ b/LayoutTests/http/tests/media/media-source/mediasource-remove.html
@@ -19,7 +19,7 @@
}, "remove");
test.done();
- }, "Test remove with an negative start.");
+ }, "Test remove with a negative start.");
mediasource_test(function(test, mediaElement, mediaSource)
{
@@ -69,6 +69,30 @@
{
var sourceBuffer = mediaSource.addSourceBuffer(MediaSourceUtil.AUDIO_VIDEO_TYPE);
+ assert_throws("InvalidAccessError", function()
+ {
+ sourceBuffer.remove(0, Number.NEGATIVE_INFINITY);
+ }, "remove");
+
+ test.done();
+ }, "Test remove with a NEGATIVE_INFINITY end.");
+
+ mediasource_test(function(test, mediaElement, mediaSource)
+ {
+ var sourceBuffer = mediaSource.addSourceBuffer(MediaSourceUtil.AUDIO_VIDEO_TYPE);
+
+ assert_throws("InvalidAccessError", function()
+ {
+ sourceBuffer.remove(0, Number.NaN);
+ }, "remove");
+
+ test.done();
+ }, "Test remove with a NaN end.");
+
+ mediasource_test(function(test, mediaElement, mediaSource)
+ {
+ var sourceBuffer = mediaSource.addSourceBuffer(MediaSourceUtil.AUDIO_VIDEO_TYPE);
+
mediaSource.duration = 10;
mediaSource.removeSourceBuffer(sourceBuffer);
@@ -223,9 +247,7 @@
removeAppendedDataTests(function(test, sourceBuffer, bufferedRangeEnd, subType)
{
- // Using MAX_VALUE rather than POSITIVE_INFINITY here due to lack
- // of 'unrestricted' on end parameter. (See comment in SourceBuffer.idl)
- removeAndCheckBufferedRanges(test, sourceBuffer, 0, Number.MAX_VALUE, "{ }");
+ removeAndCheckBufferedRanges(test, sourceBuffer, 0, Number.POSITIVE_INFINITY, "{ }");
}, "Test removing all appended data.");
removeAppendedDataTests(function(test, sourceBuffer, bufferedRangeEnd, subType)

Powered by Google App Engine
This is Rietveld 408576698