Issue 453473002: Change SourceBuffer.remove() end parameter to unrestricted double.

Issue 453473002: Change SourceBuffer.remove() end parameter to unrestricted double. (Closed)

Created:
6 years, 4 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 4 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Change SourceBuffer.remove() end parameter to unrestricted double. This change just brings the code in line with the current spec text. BUG=397769 TEST=LayoutTest/http/tests/media/media-source/mediasource-remove.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179927

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -19 lines)			Patch
M	LayoutTests/http/tests/media/media-source/mediasource-remove.html	View	3 chunks	+26 lines, -4 lines	0 comments	Download
M	LayoutTests/http/tests/media/media-source/mediasource-remove-expected.txt	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	Source/modules/mediasource/SourceBuffer.cpp	View	1 chunk	+14 lines, -11 lines	2 comments	Download
M	Source/modules/mediasource/SourceBuffer.idl	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

lgtm https://codereview.chromium.org/453473002/diff/1/Source/modules/mediasource/SourceBuffer.cpp File Source/modules/mediasource/SourceBuffer.cpp (right): https://codereview.chromium.org/453473002/diff/1/Source/modules/mediasource/SourceBuffer.cpp#newcode354 Source/modules/mediasource/SourceBuffer.cpp:354: // 7. Run the range removal algorithm with ...

6 years, 4 months ago (2014-08-11 07:53:55 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/453473002/1

6 years, 4 months ago (2014-08-11 07:54:52 UTC) #3

acolwell GONE FROM CHROMIUM

6 years, 4 months ago (2014-08-11 16:21:34 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/453473002/diff/1/Source/modules/mediasource/S...
File Source/modules/mediasource/SourceBuffer.cpp (right):

https://codereview.chromium.org/453473002/diff/1/Source/modules/mediasource/S...
Source/modules/mediasource/SourceBuffer.cpp:354: // 7. Run the range removal
algorithm with start and end as the start and end of the removal range.
On 2014/08/11 07:53:55, philipj wrote:
> Looks equivalent, but it would be nice to factor out the range removal
algorithm
> eventually.
Yes. The range removal algorithm was added in one of the most recent spec
updates. I was planning on factoring out that functionality in a later CL so the
code matches the spec.

Expand Messages | Collapse Messages