Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 453393002: Cleanup duplicated namespace in AnimationTranslationUtil (Closed)

Created:
6 years, 4 months ago by heeyoun.lee
Modified:
6 years, 4 months ago
Reviewers:
haraken, kangil_
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup duplicated namespace in AnimationTranslationUtil Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180044

Patch Set 1 #

Total comments: 2

Patch Set 2 : Cleanup duplicated namespace in AnimationTranslationUtil #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M Source/core/animation/AnimationTranslationUtil.h View 1 1 chunk +4 lines, -7 lines 0 comments Download
M Source/core/animation/AnimationTranslationUtil.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationTranslationUtilTest.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
heeyoun.lee
6 years, 4 months ago (2014-08-11 07:59:49 UTC) #1
kangil_
This is a blink name space clean-up patch. Not an owner lgtm.
6 years, 4 months ago (2014-08-11 10:26:24 UTC) #2
kangil_
On 2014/08/11 10:26:24, kangil_ wrote: > This is a blink name space clean-up patch. Not ...
6 years, 4 months ago (2014-08-11 10:29:44 UTC) #3
haraken
https://codereview.chromium.org/453393002/diff/1/Source/core/animation/AnimationTranslationUtil.h File Source/core/animation/AnimationTranslationUtil.h (right): https://codereview.chromium.org/453393002/diff/1/Source/core/animation/AnimationTranslationUtil.h#newcode39 Source/core/animation/AnimationTranslationUtil.h:39: class WebFilterOperations; Alphabetical order please. I guess this will ...
6 years, 4 months ago (2014-08-11 10:34:53 UTC) #4
kangil_
@heeyoun: Would you incorporate review comments in next patch set? https://codereview.chromium.org/453393002/diff/1/Source/core/animation/AnimationTranslationUtilTest.cpp File Source/core/animation/AnimationTranslationUtilTest.cpp (right): https://codereview.chromium.org/453393002/diff/1/Source/core/animation/AnimationTranslationUtilTest.cpp#newcode90 ...
6 years, 4 months ago (2014-08-11 10:39:22 UTC) #5
kangil_
Exclude owners till peer review is finished. :)
6 years, 4 months ago (2014-08-11 10:53:38 UTC) #6
kangil_
Not an owner lgtm. @haraken: Would you please take a look? Thanks!
6 years, 4 months ago (2014-08-12 02:46:50 UTC) #7
haraken
LGTM
6 years, 4 months ago (2014-08-12 03:21:05 UTC) #8
heeyoun.lee
The CQ bit was checked by heeyoun.lee@samsung.com
6 years, 4 months ago (2014-08-12 04:02:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heeyoun.lee@samsung.com/453393002/20001
6 years, 4 months ago (2014-08-12 04:03:42 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-12 04:49:52 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 04:56:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/19386)
6 years, 4 months ago (2014-08-12 04:56:09 UTC) #13
heeyoun.lee
The CQ bit was checked by heeyoun.lee@samsung.com
6 years, 4 months ago (2014-08-12 06:39:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heeyoun.lee@samsung.com/453393002/20001
6 years, 4 months ago (2014-08-12 06:40:31 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 07:45:43 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 08:31:22 UTC) #17
Message was sent while issue was closed.
Change committed as 180044

Powered by Google App Engine
This is Rietveld 408576698