Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 453383002: More lazy deoptimization in Turbofan (binops, loads/stores) (Closed)

Created:
6 years, 4 months ago by Jarin
Modified:
6 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

More lazy deoptimization in Turbofan (binops, loads/stores) Deoptimizing binory operations, (Load|Store)(Property|Named), constructors. This also fixes safepoint lookup to account for lazily deoptimized code. BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23029

Patch Set 1 #

Patch Set 2 : Merge with reland of r23020 #

Patch Set 3 : Attempt to fix the 64-bit Windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -89 lines) Patch
M src/compiler/arm/linkage-arm.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 8 chunks +19 lines, -9 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 39 chunks +109 lines, -33 lines 0 comments Download
M src/compiler/code-generator.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 5 chunks +16 lines, -9 lines 0 comments Download
M src/compiler/js-operator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/linkage.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M src/compiler/linkage-impl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/operator-properties-inl.h View 1 3 chunks +50 lines, -10 lines 0 comments Download
M src/compiler/register-allocator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 chunks +66 lines, -0 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 4 chunks +24 lines, -5 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 16 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jarin
Could you take a look, please?
6 years, 4 months ago (2014-08-11 07:11:24 UTC) #1
Jarin
On 2014/08/11 07:11:24, jarin wrote: > Could you take a look, please? Merged with the ...
6 years, 4 months ago (2014-08-11 08:15:17 UTC) #2
Benedikt Meurer
lgtm
6 years, 4 months ago (2014-08-11 09:28:23 UTC) #3
Jarin
6 years, 4 months ago (2014-08-11 10:42:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as 23029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698