Issue 453333002: Fix string assert and dead code which caused it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453333002: Fix string assert and dead code which caused it. (Closed)

Created:
6 years, 4 months ago by bungeman-skia

Modified:
6 years, 4 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix string assert and dead code which caused it. Running tools with a '--' parameter caused SkString to assert here incorrectly. SkString::remove should allow the entire contents of a string to be removed. The code in the flags parser which caused this call is dead and should be removed. Committed: https://skia.googlesource.com/skia/+/dfb9bc41a2e68714b123b47b3e163ab2524a223b

Patch Set 1 #

Patch Set 2 : Clarify asserts, avoid potential overflow. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	src/core/SkString.cpp	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download
	M	tools/flags/SkCommandLineFlags.cpp	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/453333002/20001

6 years, 4 months ago (2014-08-11 14:12:36 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-11 14:20:01 UTC) #5

Message was sent while issue was closed.

Change committed as dfb9bc41a2e68714b123b47b3e163ab2524a223b

Expand Messages | Collapse Messages