Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1726)

Issue 453243003: Fix keyTimes list length of from/to/by animations. (Closed)

Created:
6 years, 4 months ago by reni
Modified:
6 years, 4 months ago
Reviewers:
krit, fs
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, pdr., Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix keyTimes list length of from/to/by animations. For from/to/by animations, the length of keyTimes and keyPoints attribute if are specified must be equal and must have at least 2 values. R=fs@opera.com,dschulze@chromium.org BUG=377050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180390

Patch Set 1 #

Patch Set 2 : Updated patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
A + LayoutTests/svg/animations/invalid-keytime-number-crash.html View 1 2 chunks +4 lines, -2 lines 0 comments Download
A + LayoutTests/svg/animations/invalid-keytime-number-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reni
Added a check for from/to/by animations that if both keypoints and keytimes attributes are defined ...
6 years, 4 months ago (2014-08-14 11:33:17 UTC) #1
fs
LGTM (some parts of this method are a bit thorny...)
6 years, 4 months ago (2014-08-15 18:34:50 UTC) #2
reni
The CQ bit was checked by rhodovan.u-szeged@partner.samsung.com
6 years, 4 months ago (2014-08-15 20:25:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rhodovan.u-szeged@partner.samsung.com/453243003/20001
6 years, 4 months ago (2014-08-15 20:25:58 UTC) #4
reni
On 2014/08/15 18:34:50, fs (ooo) wrote: > LGTM (some parts of this method are a ...
6 years, 4 months ago (2014-08-15 20:58:35 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 21:34:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180390

Powered by Google App Engine
This is Rietveld 408576698