Issue 453233002: Hiding cast of WebCore WindRule to SkPath::FillType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 453233002: Hiding cast of WebCore WindRule to SkPath::FillType (Closed)

Created:
6 years, 4 months ago by shreeramk

Modified:
6 years, 4 months ago

Reviewers:
tfarina, f(malita)

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Hiding cast of WebCore WindRule to SkPath::FillType Adding a inline helper function in SkiaUtils.h to hide the cast of WebCore Windrule to SkPath::FillType Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179968

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -4 lines)			Patch
M	Source/platform/graphics/GraphicsContext.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/platform/graphics/Path.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/graphics/skia/SkiaUtils.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/453233002/1

6 years, 4 months ago (2014-08-11 15:00:41 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-08-11 15:41:45 UTC) #4

Message was sent while issue was closed.

Change committed as 179968