Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: components/copresence/mediums/audio/audio_recorder_unittest.cc

Issue 453203002: Fixing memory leak in TimedMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merging to HEAD Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/mediums/audio/audio_recorder_unittest.cc
diff --git a/components/copresence/mediums/audio/audio_recorder_unittest.cc b/components/copresence/mediums/audio/audio_recorder_unittest.cc
index 900dffbc8a16fbcec415d7bafe6a0472d777da6c..69c856aa717aebdf77ae74c2f9e7c3338ee026b2 100644
--- a/components/copresence/mediums/audio/audio_recorder_unittest.cc
+++ b/components/copresence/mediums/audio/audio_recorder_unittest.cc
@@ -189,18 +189,14 @@ class AudioRecorderTest : public testing::Test {
content::TestBrowserThreadBundle thread_bundle_;
};
-#if defined(OS_WIN) || defined(OS_MACOSX)
-// Windows does not let us use non-OS params. The tests need to be rewritten to
-// use the params provided to us by the audio manager rather than setting our
-// own params.
+// TODO(rkc): These tests are broken on all platforms.
+// On Windows and Mac, we cannot use non-OS params. The tests need to be
+// rewritten to use the params provided to us by the audio manager
+// rather than setting our own params.
+// On Linux, there is a memory leak in the audio code during initialization.
#define MAYBE_BasicRecordAndStop DISABLED_BasicRecordAndStop
#define MAYBE_OutOfOrderRecordAndStopMultiple DISABLED_OutOfOrderRecordAndStopMultiple
#define MAYBE_RecordingEndToEnd DISABLED_RecordingEndToEnd
-#else
-#define MAYBE_BasicRecordAndStop BasicRecordAndStop
-#define MAYBE_OutOfOrderRecordAndStopMultiple OutOfOrderRecordAndStopMultiple
-#define MAYBE_RecordingEndToEnd RecordingEndToEnd
-#endif
TEST_F(AudioRecorderTest, MAYBE_BasicRecordAndStop) {
CreateSimpleRecorder();

Powered by Google App Engine
This is Rietveld 408576698