Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: components/copresence/handlers/audio/audio_directive_handler_unittest.cc

Issue 453203002: Fixing memory leak in TimedMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merging to HEAD Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/copresence/handlers/audio/audio_directive_list_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/copresence/handlers/audio/audio_directive_handler_unittest.cc
diff --git a/components/copresence/handlers/audio/audio_directive_handler_unittest.cc b/components/copresence/handlers/audio/audio_directive_handler_unittest.cc
index 4faa6974e39cafa639832a777655940b005854a4..6f90e8f56b07f96018fc1e18d56ac8622db925f3 100644
--- a/components/copresence/handlers/audio/audio_directive_handler_unittest.cc
+++ b/components/copresence/handlers/audio/audio_directive_handler_unittest.cc
@@ -77,10 +77,8 @@ class AudioDirectiveHandlerTest : public testing::Test {
DISALLOW_COPY_AND_ASSIGN(AudioDirectiveHandlerTest);
};
-// TODO(rkc): Find and fix the memory leak here.
-#define MAYBE_Basic DISABLED_Basic
-
-TEST_F(AudioDirectiveHandlerTest, MAYBE_Basic) {
+// TODO(rkc): This test is broken, possibly due to the changes for audible.
+TEST_F(AudioDirectiveHandlerTest, DISABLED_Basic) {
const base::TimeDelta kSmallTtl = base::TimeDelta::FromMilliseconds(0x1337);
const base::TimeDelta kLargeTtl = base::TimeDelta::FromSeconds(0x7331);
« no previous file with comments | « no previous file | components/copresence/handlers/audio/audio_directive_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698