Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: components/copresence/handlers/audio/audio_directive_list_unittest.cc

Issue 453203002: Fixing memory leak in TimedMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/handlers/audio/audio_directive_list_unittest.cc
diff --git a/components/copresence/handlers/audio/audio_directive_list_unittest.cc b/components/copresence/handlers/audio/audio_directive_list_unittest.cc
index f237561b1bc9a32c93e99bdcd872d6bce4f77ef2..7019259c76a55376edcc66fcc8228f225f6104e2 100644
--- a/components/copresence/handlers/audio/audio_directive_list_unittest.cc
+++ b/components/copresence/handlers/audio/audio_directive_list_unittest.cc
@@ -33,10 +33,7 @@ class AudioDirectiveListTest : public testing::Test {
scoped_ptr<AudioDirectiveList> directive_list_;
};
-// TODO(rkc): Find and fix the memory leak here.
-#define MAYBE_Basic DISABLED_Basic
-
-TEST_F(AudioDirectiveListTest, MAYBE_Basic) {
+TEST_F(AudioDirectiveListTest, Basic) {
const base::TimeDelta kZeroTtl = base::TimeDelta::FromMilliseconds(0);
const base::TimeDelta kLargeTtl = base::TimeDelta::FromSeconds(0x7331);
@@ -54,10 +51,7 @@ TEST_F(AudioDirectiveListTest, MAYBE_Basic) {
EXPECT_EQ("op_id3", directive_list_->GetNextReceive()->op_id);
}
-// TODO(rkc): Find out why this is breaking on bots and fix it.
-#define MAYBE_OutOfOrderAndMultiple DISABLED_OutOfOrderAndMultiple
-
-TEST_F(AudioDirectiveListTest, MAYBE_OutOfOrderAndMultiple) {
+TEST_F(AudioDirectiveListTest, OutOfOrderAndMultiple) {
const base::TimeDelta kZeroTtl = base::TimeDelta::FromMilliseconds(0);
const base::TimeDelta kLargeTtl = base::TimeDelta::FromSeconds(0x7331);

Powered by Google App Engine
This is Rietveld 408576698