Expose CHROMIUM_texture_mailbox/sync_point stubs in mojo public headers

Expose CHROMIUM_texture_mailbox/sync_point stubs in mojo public headers

BUG=
R=piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289367

[jamesr, 2014-08-12 18:22:34]

This generates separate thunk tables for extensions so apps can decide which
they want linked in by exposing the appropriate MojoSet...Thunks function from
their app (in practice, this probably means linking in the bits of the SDK we
provide that hooks these up).

[piman, 2014-08-12 20:50:35]

lgtm

https://codereview.chromium.org/453163002/diff/40001/gpu/command_buffer/build...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/453163002/diff/40001/gpu/command_buffer/build...
gpu/command_buffer/build_gles2_cmd_buffer.py:8332: "CHROMIUM_sync_point")
nit: would it make sense to gather all extensions from the entrypoint definition
list, and derive the list of extension files from there?

[jamesr, 2014-08-12 20:54:51]

On 2014/08/12 20:50:35, piman (OOO) wrote:
> lgtm
> 
>
https://codereview.chromium.org/453163002/diff/40001/gpu/command_buffer/build...
> File gpu/command_buffer/build_gles2_cmd_buffer.py (right):
> 
>
https://codereview.chromium.org/453163002/diff/40001/gpu/command_buffer/build...
> gpu/command_buffer/build_gles2_cmd_buffer.py:8332: "CHROMIUM_sync_point")
> nit: would it make sense to gather all extensions from the entrypoint
definition
> list, and derive the list of extension files from there?

It'd be great to have all extensions tagged with their name, but even then we'll
still want to have an explicit mapping of extension names -> file names I think
so that we can choose what to include in the 'mojo sdk' and maintain stable
names.  Maybe we can have a convention on how our extension 'name' maps to the
filename?  Not sure how we wanna handle multiple names (i.e. a KHR, ARB and EXT
extension name for the same thing).

[jamesr, 2014-08-12 22:31:56]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-08-12 22:34:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/453163002/60001

[jamesr, 2014-08-13 00:56:45]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-08-13 01:07:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/453163002/80001

[commit-bot: I haz the power, 2014-08-13 04:15:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-13 04:19:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 04:19:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jamesr, 2014-08-13 04:54:17]

https://codereview.chromium.org/453163002/diff/80001/mojo/gles2/gles2_impl.cc
File mojo/gles2/gles2_impl.cc (right):

https://codereview.chromium.org/453163002/diff/80001/mojo/gles2/gles2_impl.cc...
mojo/gles2/gles2_impl.cc:9: #include "gpu/GLES2/gl2extchromium.h"
i added this and the GL_GLEXT_PROTOTYPES define to try to get
MojoGLES2gl{InsertSyncPoint,ProduceTexture,etc} to be marked as exported from
mojo_gles2_impl component. is that the right way to go about this?

[jamesr, 2014-08-13 17:59:14]

On 2014/08/13 04:54:17, jamesr wrote:
> https://codereview.chromium.org/453163002/diff/80001/mojo/gles2/gles2_impl.cc
> File mojo/gles2/gles2_impl.cc (right):
> 
>
https://codereview.chromium.org/453163002/diff/80001/mojo/gles2/gles2_impl.cc...
> mojo/gles2/gles2_impl.cc:9: #include "gpu/GLES2/gl2extchromium.h"
> i added this and the GL_GLEXT_PROTOTYPES define to try to get
> MojoGLES2gl{InsertSyncPoint,ProduceTexture,etc} to be marked as exported from
> mojo_gles2_impl component. is that the right way to go about this?

It looks like this is (roughly) what the other GL binding targets do and it's
making the trybots happy, so I'll go ahead and land with this.  Happy to refine
later if this isn't quite right.

[jamesr, 2014-08-13 17:59:18]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-08-13 18:01:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/453163002/100001

[commit-bot: I haz the power, 2014-08-13 20:03:09]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-13 20:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 20:14:40]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jamesr, 2014-08-13 20:38:08]

Committed patchset #6 manually as 289367 (presubmit successful).