Issue 453153002: Disable PluginTest.GetURL on Mac since it's failing even with retries sometimes.

Issue 453153002: Disable PluginTest.GetURL on Mac since it's failing even with retries sometimes. (Closed)

Created:
6 years, 4 months ago by jam

Modified:
6 years, 4 months ago

Reviewers:
Avi (use Gerrit), jabdelmalek

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable PluginTest.GetURL on Mac since it's failing even with retries sometimes. BUG=402164 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288448

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	content/browser/plugin_browsertest.cc	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

https://codereview.chromium.org/453153002/diff/1/content/browser/plugin_browsertest.cc File content/browser/plugin_browsertest.cc (right): https://codereview.chromium.org/453153002/diff/1/content/browser/plugin_browsertest.cc#newcode225 content/browser/plugin_browsertest.cc:225: #if !defined(OS_MACOSX) // http://crbug.com/402164 Not DISABLED_?

6 years, 4 months ago (2014-08-08 22:43:21 UTC) #2

jabdelmalek

On 2014/08/08 22:43:21, Avi wrote: > https://codereview.chromium.org/453153002/diff/1/content/browser/plugin_browsertest.cc > File content/browser/plugin_browsertest.cc (right): > > https://codereview.chromium.org/453153002/diff/1/content/browser/plugin_browsertest.cc#newcode225 > ...

6 years, 4 months ago (2014-08-08 22:50:31 UTC) #3

Avi (use Gerrit)

6 years, 4 months ago (2014-08-08 22:51:02 UTC) #4

On 2014/08/08 22:50:31, jabdelmalek wrote:
> On 2014/08/08 22:43:21, Avi wrote:
> >
>
https://codereview.chromium.org/453153002/diff/1/content/browser/plugin_brows...
> > File content/browser/plugin_browsertest.cc (right):
> > 
> >
>
https://codereview.chromium.org/453153002/diff/1/content/browser/plugin_brows...
> > content/browser/plugin_browsertest.cc:225: #if !defined(OS_MACOSX)  //
> > http://crbug.com/402164
> > Not DISABLED_?
> 
> because of the awkward MAYBE already there :(

Shrug. LGTM

Expand Messages | Collapse Messages