Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 453143002: sync: Fix serialization in proto_value_conversions (Closed)

Created:
6 years, 4 months ago by rlarocque
Modified:
6 years, 4 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

sync: Fix serialization in proto_value_conversions Adds proper serialiation for the 'initial_sync_in_progress' flag. This should have been part of r284159. BUG=351005 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sync/protocol/proto_value_conversions.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rlarocque
Please review.
6 years, 4 months ago (2014-08-09 00:06:52 UTC) #1
maniscalco
lgtm
6 years, 4 months ago (2014-08-09 00:14:51 UTC) #2
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 4 months ago (2014-08-09 00:18:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/453143002/1
6 years, 4 months ago (2014-08-09 00:24:15 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 02:32:05 UTC) #5
Message was sent while issue was closed.
Change committed as 288494

Powered by Google App Engine
This is Rietveld 408576698