Only allow webrtc HW offload for H264 encode for extension process.

content/renderer/media/rtc_video_encoder_factory.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/rtc_video_encoder_factory.h"
 
+#include "base/command_line.h"
 #include "content/common/gpu/client/gpu_video_encode_accelerator_host.h"
+#include "content/public/common/content_switches.h"
 #include "content/renderer/media/rtc_video_encoder.h"
 #include "media/filters/gpu_video_accelerator_factories.h"
 #include "media/video/video_encode_accelerator.h"
 
 namespace content {
 
 namespace {
 
 // Translate from media::VideoEncodeAccelerator::SupportedProfile to
 // one or more instances of cricket::WebRtcVideoEncoderFactory::VideoCodec
 void VEAToWebRTCCodecs(
     std::vector<cricket::WebRtcVideoEncoderFactory::VideoCodec>* codecs,
     const media::VideoEncodeAccelerator::SupportedProfile& profile) {
   int width = profile.max_resolution.width();
   int height = profile.max_resolution.height();
   int fps = profile.max_framerate.numerator;
   DCHECK_EQ(profile.max_framerate.denominator, 1U);
 
   if (profile.profile >= media::VP8PROFILE_MIN &&
       profile.profile <= media::VP8PROFILE_MAX) {
     codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec(
         webrtc::kVideoCodecVP8, "VP8", width, height, fps));
   } else if (profile.profile >= media::H264PROFILE_MIN &&
              profile.profile <= media::H264PROFILE_MAX) {
     codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec(
         webrtc::kVideoCodecGeneric, "CAST1", width, height, fps));
-    codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec(
-        webrtc::kVideoCodecH264, "H264", width, height, fps));
+    const base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
+    if (cmd_line->HasSwitch(switches::kEnableWebRtcHWH264Encoding)) {

[Pawel Osciak, 2014/08/19 01:30:27]

Could we please have this together with the kEnableWebRtcHWVp8Encoding flag,
i.e.:
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/gpu...
https://code.google.com/p/chromium/codesearch#chromium/src/content/common/gpu...

We could also move it to here out of there if that's preferable, but they should
be together.

[hshi1, 2014/08/19 17:34:49]

You mean also check for the VP8 flag above? Done.

[Pawel Osciak, 2014/08/20 01:49:29]

Not exactly, I meant we should not have checks for those flags separately, in
multiple places. We shouldn't have one check in GetSupportedProfiles and one
here. They have to be together in GetSupportedProfiles ideally, otherwise we'll
lose track of those things.

Also, I think that a method that is supposed to only convert codecs is maybe not
the right place to do this check. If anywhere, could we please have it at least
at the call site to GetSupportedProfiles or in the impl of GSP() itself.

+      codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec(
+          webrtc::kVideoCodecH264, "H264", width, height, fps));
+    }
   }
 }
 
 // Translate from cricket::WebRtcVideoEncoderFactory::VideoCodec to
 // media::VideoCodecProfile.  Pick a default profile for each codec type.
 media::VideoCodecProfile WebRTCCodecToVideoCodecProfile(
     webrtc::VideoCodecType type) {
   switch (type) {
     case webrtc::kVideoCodecVP8:
       return media::VP8PROFILE_ANY;
@@ skipping 44 matching lines @@
 RTCVideoEncoderFactory::codecs() const {
   return codecs_;
 }
 
 void RTCVideoEncoderFactory::DestroyVideoEncoder(
     webrtc::VideoEncoder* encoder) {
   delete encoder;
 }
 
 }  // namespace content